linux-kernel - Re: [PATCH] Changes to integrate RAR with SEP and fix RAR problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 Oct 2009 23:22:17 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mark Allyn <mark.a.allyn@...el.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com, greg@...ah.com,
	charles.f.johnson@...el.com, Mark Allyn <mark.a.allyn@...el.com>
Subject: Re: [PATCH] Changes to integrate RAR with SEP and fix RAR problems

> @@ -121,7 +121,7 @@ source "drivers/staging/hv/Kconfig"
>  
>  source "drivers/staging/vme/Kconfig"
>  
> -source "drivers/staging/rar/Kconfig"
> +source "drivers/staging/rar_register/Kconfig"

Its impossible to compare changes in diffs if you move them around and
then diff them. Please don't do that. Produce the diffs using the same
directory - it can move anyway when the thing comes out of staging

If you must move something then do the move and the changes as two
separate patches so it is clear. You do seem to have also done things
like reformatted the code, or worked off an old tree not the kernel one
for the changes which isn't helpful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/