linux-kernel - Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 07 Oct 2009 01:48:29 -0400
From:	john cooper <john.cooper@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Christian Borntraeger <borntraeger@...ibm.com>,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, john.cooper@...hat.com
Subject: Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

Rusty Russell wrote:
> Also, I've been convinced to just hand over the 20 byte serial number
> since we're revisiting this.  It's simple, and there's no clear consensus.

I'm fine with this approach as it is where
I originally started with this Sisyphus Patch.
My bias toward pressing the ATA identify
interface into service here was just to reuse
an existing interface and make life easier
from the perspective of the guest. 

On the subject of retrieving the S/N alone, this
is the form of the simplistic ioctl originally
used to do so:

    unsigned char sn[80];
      :
    sn[0] = sizeof(sn);
    ioctl(fd, VBLK_GET_SN, &sn);

-john

-- 
john.cooper@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/