linux-kernel - Xilinx SYSACE driver and 8-bit attachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d3f23370910070013u6307bc42hf7ab243b52d007df@mail.gmail.com>
Date:	Wed, 7 Oct 2009 17:13:22 +1000
From:	John Williams <john.williams@...alogix.com>
To:	Linux Kernel list <linux-kernel@...r.kernel.org>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Michal Simek <michal.simek@...alogix.com>,
	John Linn <John.Linn@...inx.com>,
	David DeBonis <ddeboni@...inx.com>,
	Stephen Neuendorffer <stephen.neuendorffer@...inx.com>
Subject: Xilinx SYSACE driver and 8-bit attachment

Hi Grant (it's your driver :) and David D ( and your DTS generator :)

I've just debugged a failure on a board with an 8-bit sysAce
connection - I had an infinite "kicking stalled FSM" loop on driver
load.

Turns out that the way the driver probes for an 8-bit connection:

if (of_find_property(op->node, "8-bit", NULL))
 ...

doesn't match the properties generated by Xilinx's device tree generator:

               SysACE_CompactFlash: sysace@...00000 {
                        compatible = "xlnx,xps-sysace-1.01.a",
"xlnx,xps-sysace-1.00.a";
                        interrupt-parent = <&Interrupt_Cntlr>;
                        interrupts = < 5 2 >;
                        reg = < 0x83600000 0x10000 >;
                        xlnx,family = "spartan6";
                        xlnx,mem-width = <0x8>;

So, the question is, which should change?

A temporary hard-code to 8-bit width fixes the bug for me, so I'm
certain it's just this OF property binding problem.

Let me know if we should link the DTS list into this as well.

Thanks,

John
--
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com  p: +61-7-30090663  f: +61-7-30090663
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/