linux-kernel - Re: [PATCH 3/5] checkpatch: add a blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3hbubv779.fsf@intrepid.localdomain>
Date:	Wed, 07 Oct 2009 12:17:46 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Andy Whitcroft <apw@...onical.com>, Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist

Daniel Walker <dwalker@...o99.com> writes:

> This thread is specifically about checkpatch errors .. checkpatch
> warnings can be ignored, but errors you can't usually ignore..

Of course I can and do :-)

> If your
> ignoring errors then either checkpatch is producing bogus output that
> needs to be corrected, or it's something you really should fix..

Neither.
But unfortunately I don't have examples handy.

My POV must be a bit different: I treat errors like another class of
warnings (perhaps more important that "mere" warnings but still not
authoritative).

This is BTW precisely what is needed WRT to that chunk of code
(include/trace/events/ext4.h, I assume checkpatch produces "error"
there) - though I think I'd format it a bit differently.


Perhaps checkpatch should stop producing "errors" (which are meaningless
as checkpatch has no authority to veto anything - a human has to decide)
and should simply give some severity code?
OTOH I ignore error/warning distinction completely, perhaps the
distinction is bogus? Not sure.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/