linux-kernel - Re: [tip:timers/urgent] NOHZ: update idle state also when NOHZ is inactive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ACC992F.3060001@redhat.com>
Date:	Wed, 07 Oct 2009 09:35:43 -0400
From:	Rik van Riel <riel@...hat.com>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	venkatesh.pallipadi@...el.com, greg@...ah.com, riel@...hat.com,
	steven@...inklabs.net, ext-eero.nurkkala@...ia.com,
	tglx@...utronix.de
CC:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/urgent] NOHZ: update idle state also when NOHZ is
 inactive

tip-bot for Eero Nurkkala wrote:
> Commit-ID:  fdc6f192e7e1ae80565af23cc33dc88e3dcdf184
> Gitweb:     http://git.kernel.org/tip/fdc6f192e7e1ae80565af23cc33dc88e3dcdf184
> Author:     Eero Nurkkala <ext-eero.nurkkala@...ia.com>
> AuthorDate: Wed, 7 Oct 2009 11:54:26 +0300
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Wed, 7 Oct 2009 13:05:05 +0200
> 
> NOHZ: update idle state also when NOHZ is inactive
> 
> Commit f2e21c9610991e95621a81407cdbab881226419b had unfortunate side
> effects with cpufreq governors on some systems.
> 
> If the system did not switch into NOHZ mode ts->inidle is not set when
> tick_nohz_stop_sched_tick() is called from the idle routine. Therefor
> all subsequent calls from irq_exit() to tick_nohz_stop_sched_tick()
> fail to call tick_nohz_start_idle(). This results in bogus idle
> accounting information which is passed to cpufreq governors.
> 
> Set the inidle flag unconditionally of the NOHZ active state to keep
> the idle time accounting correct in any case.

Acked-by: Rik van Riel <riel@...hat.com>

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/