linux-kernel - Re: [PATCH 3/5] checkpatch: add a blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091007161107.72b4031b@lxorguk.ukuu.org.uk>
Date:	Wed, 7 Oct 2009 16:11:07 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Krzysztof Halasa <khc@...waw.pl>,
	Andy Whitcroft <apw@...onical.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist

> Right it's a tool .. However, you should use it and you should follow
> it. If for some reason you disagree with the tool you have to give at
> least an arguable reason why, not just "It's a guide", "I don't like the
> coding style." etc..

Those are perfectly good reasons.

> In the case of Steven's code he has an arguable reason why he's not
> following checkpatch..

Checkpatch is not very bright, it has no understanding of style beyond
playing with pattern regexps. It's a rather dim tool that helps people
get work done. (*)

When used at random to "validate" submissions to the kernel the result is
about as useful as a square wheel on a hovercraft.

Alan
(*) or as some would have it a rather dim tool used by even dimmer tools
to make noise on kernel list.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/