lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091007165250.30d8c996@lxorguk.ukuu.org.uk>
Date:	Wed, 7 Oct 2009 16:52:50 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	Krzysztof Halasa <khc@...waw.pl>,
	Andy Whitcroft <apw@...onical.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist

On Wed, 07 Oct 2009 08:41:08 -0700
Daniel Walker <dwalker@...o99.com> wrote:

> On Wed, 2009-10-07 at 16:11 +0100, Alan Cox wrote:
> > > Right it's a tool .. However, you should use it and you should follow
> > > it. If for some reason you disagree with the tool you have to give at
> > > least an arguable reason why, not just "It's a guide", "I don't like the
> > > coding style." etc..
> > 
> > Those are perfectly good reasons.
> 
> I don't think they are.. Like adding spaces for tabs is ok cause
> checkpatch is a guide right?

Yes.. if it was such a big deal someone would have updated the git commit
tools to fix them as we do to strim off trailing spaces.

They have *zero* impact on performance, maintainability or readability
providing they don't mess up the indentation - and the kernel is full of
them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ