linux-kernel - Re: [PATCH 1/7] printk: clean up return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1254937376.2134.384.camel@Joe-Laptop.home>
Date:	Wed, 07 Oct 2009 10:42:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>, mingo@...hat.com,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] printk: clean up return value

On Wed, 2009-10-07 at 17:57 +0100, Alan Jenkins wrote:
> Joe Perches wrote:
> > On Wed, 2009-10-07 at 08:36 -0700, Linus Torvalds wrote:
> >> On Wed, 7 Oct 2009, Alan Jenkins wrote:
> >>> We could fix this up, but it seems pointless.  Callers don't really care
> >>> about the extra characters added by printk().  Instead, let's return the
> >>> length of the original message as formatted (and possibly truncated)
> >>> by vscnprintf().
> >> Or we could just change it to 'void'. As Joe Perches says, nobody really 
> >> cares deeply enough for this to generally even matter.
> > Here are changes to make printk/vprintk return void
> > to the only uses I found:
> >  arch/arm/mach-iop13xx/pci.c   |    2 +-
> >  arch/arm/mach-iop13xx/setup.c |    2 +-
> >  drivers/char/mem.c            |    6 ++----
> >  drivers/md/md.c               |    3 +--
> >  drivers/md/raid5.c            |    3 ++-
> >  drivers/net/e100.c            |    9 +++++----
> >  include/linux/kernel.h        |   16 ++++++++--------
> >  include/net/sctp/sctp.h       |    6 +++---
> >  kernel/lockdep.c              |    4 ++--
> >  kernel/printk.c               |   10 +++-------
> >  net/sunrpc/svc.c              |    9 +++------
> >  11 files changed, 31 insertions(+), 39 deletions(-)
> Ok, you beat me to it.
> My second patch will depend on this.  Two questions -
> - May I add it to my series with your Signed-off-by?

Hi Alan.

Sure.  I suggest you verify it first though.

Signed-off-by: Joe Perches <joe@...ches.com>

> May I split it up, so I can CC individual maintainers with the
> relevant portions?

Please.  Thanks.  Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/