linux-kernel - Re: [PATCH 3/5] checkpatch: add a blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3my42uc24.fsf@intrepid.localdomain>
Date:	Wed, 07 Oct 2009 23:30:27 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Daniel Walker <dwalker@...o99.com>
Cc:	rostedt@...dmis.org, Andy Whitcroft <apw@...onical.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist

Daniel Walker <dwalker@...o99.com> writes:

> Just relax the submission rules so that checkpatch is basically an
> optional part of the submission process. Adding that you don't actually
> need to run it, you don't need a good reason not to follow the rules
> etc.. Or expand on it to fully explain what you think the deal is or
> should be.

Oh come on... The SubmittingPatches is a HOWTO-style document for people
who want to get their patches merged. Obviously a common sense dictates
you need a good reason to ignore this or that. "Looks better" and
"I find it easier to work with" are good reasons since this is source
code, for humans to work with.

BTW, the file says:

"Check your patches with the patch style checker prior to submission
(scripts/checkpatch.pl).  The style checker should be viewed as
a guide not as the final word.  If your code looks better with
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
a violation then its probably best left alone.

The checker reports at three levels:
 - ERROR: things that are very likely to be wrong
                               ^^^^^^
 - WARNING: things requiring careful review
 - CHECK: things requiring thought"

Only "very likely".

WRT tabs vs spaces, I wonder if using only spaces would be a better
idea. Theoretically using tabs for syntactic indentation only is better,
but the tools (editors) aren't up to the task yet.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/