linux-kernel - Re: [PATCH 4/5] usb_serial: Kill port mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910070702.32266.oliver@neukum.org>
Date:	Wed, 7 Oct 2009 07:02:31 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Alan Cox <alan@...ux.intel.com>,
	Alan Stern <stern@...land.harvard.edu>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/5] usb_serial: Kill port mutex

Am Dienstag, 6. Oktober 2009 17:06:46 schrieb Alan Cox:
> +++ b/drivers/usb/serial/opticon.c
> @@ -498,12 +498,12 @@ static int opticon_resume(struct usb_interface *intf)
>         struct usb_serial_port *port = serial->port[0];
>         int result;
>  
> -       mutex_lock(&port->mutex);
> +       mutex_lock(&port->port.mutex);
>         if (port->port.count)
>                 result = usb_submit_urb(priv->bulk_read_urb, GFP_NOIO);
>         else
>                 result = 0;
> -       mutex_unlock(&port->mutex);
> +       mutex_unlock(&port->port.mutex);
>         return result;
>  }

We will need some generic way to autoresume from open.
Resume will need to lock against open() and need to be called
from within open(). Any ideas for an unugly interface?

	Regards
		Oliver