linux-kernel - [BUG] wbsd.c: after spin_lock_bh uses spin_unlock instead spin_unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200910081518.00707.strakh@ispras.ru>
Date:	Thu, 8 Oct 2009 15:18:00 +0000
From:	Alexander Strakh <strakh@...ras.ru>
To:	Pierre Ossman <pierre@...man.eu>, sdhci-devel@...ts.ossman.eu,
	Linux Kernlel Mailing List <linux-kernel@...r.kernel.org>
Subject: [BUG] wbsd.c: after spin_lock_bh uses spin_unlock instead spin_unlock_bh

	KERNEL_VERSION: 2.6.31
	DESCRIBE:
Driver ./drivers/mmc/host/wbsd.c calls spin_lock_bh and then spin_unlock 
instead of spin_unlock_bh:

 753 static void wbsd_request(struct mmc_host *mmc, struct mmc_request *mrq)
...
 761         spin_lock_bh(&host->lock);
...
 844 done:
 845         wbsd_request_end(host, mrq);
 846
 847         spin_unlock_bh(&host->lock);
 848 }

But in wsdb_request calls spin_unlock/spin_lock instead of 
spin_unlock_bh/spin_lock_bh;

 206 static void wbsd_request_end(struct wbsd_host *host, struct mmc_request 
...
 230         spin_unlock(&host->lock);
 231         mmc_request_done(host->mmc, mrq);
 232         spin_lock(&host->lock);
 233 }

Found by : Linux Driver Verification
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/