[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091008221901.2321cca6@lxorguk.ukuu.org.uk>
Date: Thu, 8 Oct 2009 22:19:01 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Oliver Neukum <oliver@...kum.org>
Cc: Alan Stern <stern@...land.harvard.edu>, Greg KH <greg@...ah.com>,
Kernel development list <linux-kernel@...r.kernel.org>,
USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 4/5] usb_serial: Kill port mutex
On Thu, 8 Oct 2009 22:40:36 +0200
Oliver Neukum <oliver@...kum.org> wrote:
> Am Donnerstag, 8. Oktober 2009 22:06:10 schrieb Alan Stern:
>
> >
> > On further thought, unthrottle should autoresume if the device is
> > open and autosuspended (but it shouldn't do anything if the device is
> > suspended). After all, the reason for the autosuspend may have been
> > the lack of activity caused by the throttling.
> >
> > In practice this isn't likely to come up. It would be surprising if
> > throttling lasted long enough to cause an autosuspend or if the core
> > decided to throttle while the device was autosuspended and hence idle.
>
> So you say that throttle() should do an autopm_put?
You need to be very very sure you cannot lose a byte of data or have the
modem lines disrupted in any way if you do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists