linux-kernel - Re: [GIT PULL] omap fixes for v2.6.32-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091008232603.GB25892@atomide.com>
Date:	Thu, 8 Oct 2009 16:26:03 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-omap@...r.kernel.org,
	Denis Karpov <ext-denis.2.karpov@...ia.com>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: Re: [GIT PULL] omap fixes for v2.6.32-rc3

* Felipe Contreras <felipe.contreras@...il.com> [091008 15:20]:
> On Fri, Oct 9, 2009 at 1:13 AM, Felipe Contreras
> <felipe.contreras@...il.com> wrote:
> > On Fri, Oct 9, 2009 at 12:41 AM, Tony Lindgren <tony@...mide.com> wrote:
> >> * Felipe Contreras <felipe.contreras@...il.com> [091008 14:29]:
> >>> On Wed, Oct 7, 2009 at 9:51 PM, Tony Lindgren <tony@...mide.com> wrote:
> >>>

<snip snip>

> >>> The beagleboard is still not booting for me with this branch, I need
> >>> to add these two patches:
> >>>
> >>> * http://patchwork.kernel.org/patch/50721/
> >>>
> >>
> >> This should go to the mainline kernel via Samuel as it's
> >> drivers/mfd related.
> >>
> >>> This one is needed because the defconfig has:
> >>> CONFIG_TWL4030_USB=y
> >>>
> >>> * http://patchwork.kernel.org/patch/50970/
> >>>
> >>> This is needed because most people boot from an MMC.
> >>
> >> And this should go in via the mmc list.
> >
> > Should it?
> >
> > Here you can see Uwe Kleine-König sending the original patch without
> > even CC'ing the mmc list:
> > http://marc.info/?l=linux-kernel&m=124820861213849&w=2
> >
> > And it was unintentionally broken by this one:
> > http://marc.info/?l=linux-mmc&m=125249763422227&w=2
> 
> Er, actually that one was ok, the problem was introduced only in the
> final version:
> http://marc.info/?l=linux-mmc&m=125366315417006&w=2

Right, looks like Roger forgot to Cc linux-mmc.
 
> > I don't see what we are waiting for, the code is clearly broken, even
> > the compiler warns that nobody is using omap_hsmmc_probe().

I've sent Roger's patch to Andrew & linux-mmc so hopefully it will get
merged soon:

http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg00539.html

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/