linux-kernel - Re: [PATCH 06/10] x86, mce: make mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1255052730.5228.22.camel@yhuang-dev.sh.intel.com>
Date:	Fri, 09 Oct 2009 09:45:30 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	Andi Kleen <ak@...ux.intel.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/10] x86, mce: make mce_log buffer to per-CPU

On Mon, 2009-10-05 at 15:50 +0800, Hidetoshi Seto wrote: 
> Andi Kleen wrote:
> >> (This piece originates from Huang's patch, titled:
> >>  "x86, MCE: Fix bugs and issues of MCE log ring buffer")
> > 
> > You should use proper From: headers then for correct attribution.
> > 
> > -Andi
> 
> I just referred following commit we already have: 
> 
> > commit 77e26cca20013e9352a8df86a54640543304a23a
> > Author: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> > Date:   Thu Jun 11 16:04:35 2009 +0900
> > 
> >     x86, mce: Fix mce printing
> > 
> >     This patch:
> > 
> >      - Adds print_mce_head() instead of first flag
> >      - Makes the header to be printed always
> >      - Stops double printing of corrected errors
> > 
> >     [ This portion originates from Huang Ying's patch ]
> > 
> >     Originally-From: Huang Ying <ying.huang@...el.com>
> >     Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> >     LKML-Reference: <4A30AC83.5010708@...fujitsu.com>
> >     Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> You mean s/Originally-From/From/, right?
> 
> I'll update attributes if this set need to be revised or if maintainer
> (who expected to be able to set proper attributes) request me to do so.

I don't think it is a good collaboration style to copy others' patches,
do some modification and send it out, instead:

- comment on original patches
- communicate with the original author firstly
- provide another patch on top of original patches

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/