linux-kernel - Re: [PATCH] move stk17ta8's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.0910091724170.19284@wotan.suse.de>
Date:	Fri, 9 Oct 2009 17:24:51 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Paul Mundt <lethal@...ux-sh.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hannes Eder <hannes@...neseder.net>
Subject: Re: [PATCH] move stk17ta8's probe function to .devinit.text

On Sat, 11 Jul 2009, Uwe Kleine-König wrote:

> A pointer to stk17ta8_rtc_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Anton Vorontsov <avorontsov@...mvista.com>
> Cc: Alessandro Zummo <a.zummo@...ertech.it>
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> Cc: Paul Mundt <lethal@...ux-sh.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Hannes Eder <hannes@...neseder.net>
> Cc: Jiri Kosina <jkosina@...e.cz>
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> ---
>  drivers/rtc/rtc-stk17ta8.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c
> index 7d1547b..d491eb2 100644
> --- a/drivers/rtc/rtc-stk17ta8.c
> +++ b/drivers/rtc/rtc-stk17ta8.c
> @@ -286,7 +286,7 @@ static struct bin_attribute stk17ta8_nvram_attr = {
>  	.write = stk17ta8_nvram_write,
>  };
>  
> -static int __init stk17ta8_rtc_probe(struct platform_device *pdev)
> +static int __devinit stk17ta8_rtc_probe(struct platform_device *pdev)
>  {
>  	struct rtc_device *rtc;
>  	struct resource *res;

This seems to get lost ... should I take it through my tree, or is anyone 
going to merge it? Andrew? Alessandro?

-- 
Jiri Kosina
SUSE Labs, Novell Inc.