linux-kernel - Re: [PATCH 2/8] staging: hv: Changed |typedef RING_BUFFER| to |struct hv_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 Oct 2009 09:23:19 -0700
From:	Greg KH <greg@...ah.com>
To:	Steve Friedl <steve@...xwiz.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] staging: hv: Changed |typedef RING_BUFFER| to
 |struct hv_ring_buffer| throughout.

On Mon, Sep 21, 2009 at 10:40:26PM -0700, Steve Friedl wrote:
> The style guide (and Greg's prior work) have suggested that the typedef
> UPPERCASENAME style is not appropriate in the Linux kernel (even though
> it's been de rigueur in Win32 development for 20 years), so I'm fixing
> a couple more of them that remain... one at a time.
> 
> ~~~ Steve
> 
> Signed-off-by: Steve Friedl <steve@...xwiz.net>
> 
> ---
>  drivers/staging/hv/RingBuffer.c |    6 +++---

I'd rather not polish this turd anymore.  Can someone just replace the
ringbuffer.c code by using the in-kernel ringbuffer or kfifo code
instead?  I'd love to just delete this file completly, it does not
belong in the tree at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/