linux-kernel - Re: [PATCH -repost 3/4] SCSI: lpfc, fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ACF763C.5070308@emulex.com>
Date:	Fri, 9 Oct 2009 13:43:24 -0400
From:	James Smart <James.Smart@...lex.Com>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	"James.Bottomley@...e.de" <James.Bottomley@...e.de>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -repost 3/4] SCSI: lpfc, fix memory leak

Acked-by: James Smart <james.smart@...lex.com>

-- james s

Jiri Slaby wrote:
> Stanse found a memory leak on one fail path in lpfc_sli4_read_rev.
>
> Add there kfree.
>
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: James Smart <james.smart@...lex.com>
> Cc: James E.J. Bottomley <James.Bottomley@...e.de>
> ---
>  drivers/scsi/lpfc/lpfc_sli.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 43cbe33..7750868 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -4211,6 +4211,7 @@ lpfc_sli4_read_rev(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq,
>  	if (rc) {
>  		dma_free_coherent(&phba->pcidev->dev, dma_size,
>  				  dmabuf->virt, dmabuf->phys);
> +		kfree(dmabuf);
>  		return -EIO;
>  	}
>  
>   
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/