linux-kernel - Re: [PATCH 2/2] init/do_mounts.c: replace polling for root device with devtmpfs_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 Oct 2009 10:30:40 -0700
From:	Greg KH <greg@...ah.com>
To:	tom.leiming@...il.com
Cc:	linux-kernel@...r.kernel.org, kay.sievers@...y.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/2] init/do_mounts.c: replace polling for root device
 with devtmpfs_wait_for_dev v1

On Thu, Aug 06, 2009 at 05:40:42PM +0800, tom.leiming@...il.com wrote:
> From: Ming Lei <tom.leiming@...il.com>
> 
> This patch removes the polling for root device if rootwait parameter is
> passed to kernel and CONFIG_DEVTMPFS is enabled. This way can lead to
> a faster boot, especially booting from some asynchronous block device
> (such as usb mass storage, mmc card, ...)
> 
> The patch has been verified in beagle board(mmc card as root device).
> 
> Signed-off-by: Ming Lei <tom.leiming@...il.com>
> ---
>  init/do_mounts.c |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index aa56007..46f0248 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -364,6 +364,7 @@ void __init mount_root(void)
>  void __init prepare_namespace(void)
>  {
>  	int is_floppy;
> +	int ret;
>  
>  	if (root_delay) {
>  		printk(KERN_INFO "Waiting %dsec before mounting root device...\n",
> @@ -371,6 +372,7 @@ void __init prepare_namespace(void)
>  		ssleep(root_delay);
>  	}
>  
> +#ifndef CONFIG_DEVTMPFS
>  	/*
>  	 * wait for the known devices to complete their probing
>  	 *
> @@ -379,6 +381,7 @@ void __init prepare_namespace(void)
>  	 * for the touchpad of a laptop to initialize.
>  	 */
>  	wait_for_device_probe();
> +#endif

Any way to do this without the #ifdef mess in the file?  That's pretty
ugly, and hard to maintain.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/