linux-kernel - Re: staging: where to put system-wide includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091009203802.GD2040@elf.ucw.cz>
Date:	Fri, 9 Oct 2009 22:38:02 +0200
From:	Pavel Machek <pavel@....cz>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: staging: where to put system-wide includes

On Thu 2009-10-08 14:40:27, Christoph Hellwig wrote:
> On Thu, Oct 08, 2009 at 01:28:18PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > In staging, I need some includes that will become "system-wide" at the
> > end.
> > 
> > Is it acceptable to create drivers/staging/include/linux (and
> > friends), and then use -I magic to include those headers?
> 
> If you need system-wide inclusions it's pretty good sign that what
> you add is not a simple driver and thus should not just go into the
> staging tree.  Given that you're a long-timer kernel hackers what's the
> problem with getting your code fully up to kernel standards anyway?

Well, it is not exactly my code -- I'm trying to merge HTC Dream
support. Problem with "simply cleaning it up" is that its 122Kloc.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/