linux-kernel - Re: [PATCH] CS5535: Remove the X86 platform dependence of SND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1255185134.6883.20.camel@falcon>
Date:	Sat, 10 Oct 2009 22:32:14 +0800
From:	Wu Zhangjin <wuzhangjin@...il.com>
To:	Andres Salomon <dilinger@...labora.co.uk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-mips <linux-mips@...ux-mips.org>,
	Jaya Kumar <jayakumar.lkml@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, loongson-dev@...glegroups.com
Subject: Re: [PATCH] CS5535: Remove the X86 platform dependence of
 SND_CS5535AUDIO

Hello,

On Fri, 2009-10-09 at 00:53 -0400, Andres Salomon wrote:
> On Fri, 09 Oct 2009 11:51:27 +0800
> Wu Zhangjin <wuzhangjin@...il.com> wrote:
> 
> > On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > > There is no platform dependence of SND_CS5535AUDIO before 2.6.31,
> > > Not sure who have touched this part, but SND_CS5535AUDIO is at least
> > > available on Loongson family machines, so, Remove the platform
> > > dependence directly.
> > > 
> > > Reported-by: rixed@...pyleptic.org
> > > Signed-off-by: Wu Zhangjin <wuzhangjin@...il.com>
> > > ---
> > >  sound/pci/Kconfig |    1 -
> > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > > index fb5ee3c..75c602b 100644
> > > --- a/sound/pci/Kconfig
> > > +++ b/sound/pci/Kconfig
> > > @@ -259,7 +259,6 @@ config SND_CS5530
> > >  
> > >  config SND_CS5535AUDIO
> > >  	tristate "CS5535/CS5536 Audio"
> > > -	depends on X86 && !X86_64
> > 
> > or use this?
> > 
> > 	depends on (X86 && !X86_64) || MIPS
> > 
> > Regards,
> > 	Wu Zhangjin
> > 
> 
> 
> I'd say just remove the arch dependency (and make sure it builds and
> doesn't obviously explode w/ x86-64). There's no need for it, afaict.
> It's been there since at least 2005 (git commit 230b5c1a).
> 

Just checked the SND_CS5536AUDIO(=y and =m) option with ARCH=x86_64, no
compiling warnings & errors, but I don't have such a chip in a x86-64
machine, so, did not test the kernel yet.

Regards,
	Wu Zhangjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/