linux-kernel - Re: USB serial regression 2.6.31.1 -> 2.6.31.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Oct 2009 18:52:30 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
cc:	Josua Dietze <digidietze@...isberghof.de>,
	Ben Efros <ben@...doctor.com>,
	fangxiaozhi <huananhu@...wei.com>, Greg KH <greg@...ah.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Hugh Blemings <hugh@...mings.org>
Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2

On Sun, 11 Oct 2009, Benjamin Herrenschmidt wrote:

> 
> > Further REQUEST SENSE commands therefore requested 96 bytes of data
> > instead of the standard 18 bytes.  With LUN 0 this worked okay.  But 
> > with LUN 1 it didn't; the device reported a failure of the REQUEST 
> > SENSE.  This is what caused usb-storage to issue the device reset.
> > 
> > After the reset usb-storage continued to ask for 96 bytes of sense
> > data, and LUN 1 continued to fail the commands.  Hence the repeated
> > resets.
> 
> Maybe a better approach would be to go back to 18 bytes when it fails,
> what do you think ?

We certainly could do that.  But should we turn off the SANE_SENSE flag 
at the same time?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/