linux-kernel - Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091011110919.559da63d@tpl.lwn.net>
Date:	Sun, 11 Oct 2009 11:09:19 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	John Kacur <jkacur@...hat.com>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vincent Sanders <vince@...tec.co.uk>,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open

On Sun, 11 Oct 2009 09:19:04 -0700
Arjan van de Ven <arjan@...radead.org> wrote:

> > The more general problem of
> > 
> > 	register_chrdev
> > 					open
> > 	do something
> > 	error
> > 	unload
> > 					whoops
> > 
> > definitely needs looking at however.  
> 
> absolutely
> 
> we used to have the same issue with networking devices,
> and there it ended up with a split "allocate" and "register"

Char devs are really the same way - request_chrdev_region() and
cdev_add().  I've thought for a while that register_chrdev() should be
seen as a legacy interface and removed - LDD3 was written from that
point of view.  But that takes work, and nobody's found the issue
urgent enough to put time into...

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/