linux-kernel - Re: [PATCH] x86: Relegate CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091011103302.62bded41@infradead.org>
Date:	Sun, 11 Oct 2009 10:33:02 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, tglx@...uxtronix.de,
	hpa@...or.com
Subject: Re: [PATCH] x86: Relegate CONFIG_PAT to EMBEDDED

On Sun, 11 Oct 2009 10:04:10 -0700
Roland Dreier <rdreier@...co.com> wrote:

> Makes sense, but given that X86_PAT depends on MTRR
> 
>  config X86_PAT
>  	bool
> -	prompt "x86 PAT support"
> +	default y
> +	prompt "x86 PAT support" if EMBEDDED
>  	depends on MTRR
> 
> should we give the same treatment to the MTRR option too?  (As far as
> I can tell, MTRR defaults to n in the current Kconfig too)
> 

good point



>From db3a4eb2b16907c0651ed5d4bcdfbd395a0a7ad4 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@...ux.intel.com>
Date: Sun, 11 Oct 2009 08:40:15 -0700
Subject: [PATCH] x86: Relegate CONFIG_X86_PAT and CONFIG_MTRR to EMBEDDED

MTRR and PAT support (which got added to CPUs over 10 years ago) are no
longer really optional in that more and more things are depending on PAT
just working, including various drivers and newer versions of X.  (to not
even speak of MTRR)
Having this as a regular config option just no longer makes sense.

This patch relegates CONFIG_X86_PAT to the EMBEDDED category, in the hope to
eventually completely retire it.

Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
---
 arch/x86/Kconfig |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 4427956..2fbc3c6 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1327,7 +1327,9 @@ config MATH_EMULATION
 	  kernel, it won't hurt.
 
 config MTRR
-	bool "MTRR (Memory Type Range Register) support"
+	bool
+	default y
+	prompt "MTRR (Memory Type Range Register) support" if EMBEDDED
 	---help---
 	  On Intel P6 family processors (Pentium Pro, Pentium II and later)
 	  the Memory Type Range Registers (MTRRs) may be used to control
@@ -1393,7 +1395,8 @@ config MTRR_SANITIZER_SPARE_REG_NR_DEFAULT
 
 config X86_PAT
 	bool
-	prompt "x86 PAT support"
+	default y
+	prompt "x86 PAT support" if EMBEDDED
 	depends on MTRR
 	---help---
 	  Use PAT attributes to setup page level cache control.
-- 
1.6.2.5




-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/