linux-kernel - Re: checkpatch is not detecting bad whitespacing when using macros on formulas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AD1BB06.70309@imap.cc>
Date:	Sun, 11 Oct 2009 13:01:26 +0200
From:	Tilman Schmidt <tilman@...p.cc>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
CC:	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andy Walls <awalls@...ix.net>
Subject: Re: checkpatch is not detecting bad whitespacing when using macros
 on formulas

Mauro Carvalho Chehab schrieb:
> While reviewing a patch from Andy Walls, I noticed that checkpatch v 0.29
> didn't get any errors when bad whitespacing is used on some formulas:
> 
> $ checkpatch.pl cx23888-ir-part2_2.patch
> total: 0 errors, 0 warnings, 1237 lines checked
> 
> cx23888-ir-part2_2.patch has no obvious style problems and is ready for submission.
> 
> However, there are several places at the patch like:
> 
> +static inline u16 ns_to_clock_divider(unsigned int ns)
> +{
> +       return count_to_clock_divider(
> +                 DIV_ROUND_CLOSEST(CX23888_IR_REFCLK_FREQ/1000000 * ns, 1000));
> +}

checkpatch is already complaining too much rather than too little.
No need to add even more complaints.

The code you cite above is fine IMHO, but if you don't like it, feel
free to raise your complaints. You can do so without help from
checkpatch, too.

Jm2c
T.

-- 
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (255 bytes)