linux-kernel - Re: [PATCH -mmotm] cmpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091011144418.GF30257@vespa.holoscopio.com>
Date:	Sun, 11 Oct 2009 11:44:19 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	lenb@...nel.org
Subject: Re: [PATCH -mmotm] cmpc_acpi: depends on ACPI

On Fri, Oct 09, 2009 at 04:10:36PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix about 100 build errors/warnings when ACPI is not enabled.  E.g.:
> 
> drivers/platform/x86/cmpc_acpi.c:50: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:55: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:56: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:72: warning: 'struct acpi_device' declared inside parameter list
> drivers/platform/x86/cmpc_acpi.c:77: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:79: error: dereferencing pointer to incomplete type
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>

> ---
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- mmotm-2009-1009-0107.orig/drivers/platform/x86/Kconfig
> +++ mmotm-2009-1009-0107/drivers/platform/x86/Kconfig
> @@ -438,7 +438,7 @@ config ACPI_TOSHIBA
>  
>  config ACPI_CMPC
>  	tristate "CMPC Laptop Extras"
> -	depends on X86
> +	depends on X86 && ACPI
>  	select INPUT
>  	select BACKLIGHT_CLASS_DEVICE
>  	default n

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)