linux-kernel - Re: [PATCH 2/2] vmscan: kill shrink_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2009 17:12:32 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	kosaki.motohiro@...fujitsu.com,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mm" <linux-mm@...ck.org>
Subject: Re: [PATCH 2/2] vmscan: kill shrink_all_zones()

> >   Throuput comparision
> >   ==============================================
> >   old		2192.10 MB/s
> >   new		2222.22 MB/s
> > 
> >   ok, it's almost same throuput.
> > 
> > Cc: Rafael J. Wysocki <rjw@...k.pl>
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> 
> I have no objections to any of the two patches, but I think we may want to drop
> shrink_all_memory() altogether.  Everything should work without it and the
> reason I didn't remove it was because I saw a performance regression on one
> system without it.  It may not be worth keeping it, though.
> 
> Have you done any tests with shrink_all_memory() removed?

Honestly, I haven't try to remvoe shrink_all_memory() at all. then, I don't have any
mesurement data of shrink_all_memory.
Yes, your opinion seems reasonable. I plan to mesure it awhile after. (sorry, I haven't
enough development time in this month)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/