linux-kernel - Re: [GIT PULL] kbuild fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AD2EBC6.1000505@msgid.tls.msk.ru>
Date:	Mon, 12 Oct 2009 12:41:42 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Sam Ravnborg <sam@...nborg.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [GIT PULL] kbuild fixes

Sam Ravnborg wrote:
> Hi Linus.
> 
> A few kbuild related fixes.
[]
> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users

As has been discussed previously (and Sam has been CC'ed), the fix
is still incorrect.  It replaces "echo -ne" with "/bin/echo -ne",
but neither of the two are guaranteed to support the necessary
arguments and necessary (hexadecimal) escape sequences.  What should
be used here is printf(1).  The trivial patch below (on top of these
kbuild changes) fixes this issue.

Thanks.

/mjt

Signed-Off-By: Michael Tokarev <mjt@....msk.ru>

View attachment "echo-vs-printf.diff" of type "text/x-patch" (530 bytes)