linux-kernel - Re: move gfs2 tracepoints to inclue/trace/events dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2009 12:00:37 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Whitehouse <swhiteho@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Jason Baron <jbaron@...hat.com>, cluster-devel@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: move gfs2 tracepoints to inclue/trace/events dir


* Steven Whitehouse <swhiteho@...hat.com> wrote:

> Hi,
> 
> On Fri, 2009-10-09 at 19:45 -0400, Christoph Hellwig wrote:
> > On Fri, Oct 09, 2009 at 12:01:16PM -0400, Jason Baron wrote:
> > > hi,
> > > 
> > > I'd like to move the gfs2 tracepoints to the the common
> > > include/trace/events directory along with all of the other trace events.
> > > It makes understanding what tracepoints are available easier, and I see
> > > no reason why gfs2 should be different. For example, 'ext4.h' is already
> > > in the include/trace/events directory.
> > 
> > Folks, no.  Drivers and filesystems should be as self-contained as
> > possible.  include/trace/ is an extremly bad idea for everything that's
> > not actually global kernel functionality.  There's a reason all other
> > fs headers have moved out of include/linux, too.
> > 
> 
> That true, although there is an argument about how much such a header 
> belongs to tracing and how much it belongs to the subsystem I think.

yeah. I have no objection to adding it to include/trace/. Tracepoints 
are a fundamentally global business.

Subsystems can opt to hide their tracepoints locally, but it's better to 
have a global view about what's out there, so that it can be extended 
coherently, etc.

Would you like to carry the patch or should we apply it to the tracing 
tree?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/