linux-kernel - Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0910112150020.638-100000@netrider.rowland.org>
Date:	Sun, 11 Oct 2009 21:54:23 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
cc:	Ben Efros <ben@...doctor.com>, fangxiaozhi <huananhu@...wei.com>,
	Greg KH <greg@...ah.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Hugh Blemings <hugh@...mings.org>,
	Josua Dietze <digidietze@...isberghof.de>
Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH]

On Mon, 12 Oct 2009, Benjamin Herrenschmidt wrote:

> Don't those devices support SANE_SENSE fine on LUN 0 according to
> Alan parsing of my traces ?

Not really; the device returned only the usual 18 bytes of sense data.  
But at least it did so correctly instead of failing.

>  Heh, they may even work if I actually
> populate the SD-CARD slot, I'll try later.

Possibly, but I sure wouldn't bet on it.   :-)

> I still think it's simpler and potentially more future-proof to just
> have a back-off scenario.
> 
> Now, whether we ping pong the US_FL_SANE_SENSE flag or not is minor,
> I tend to think that your approach that doesn't touch the flag might
> indeed be better.
> 
> I'll test the patch later today.

And of course there remains the question of why the serial driver
wasn't loaded and probed.  Would it make a difference if that driver
was already loaded when you plugged in the modem?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/