linux-kernel - Re: [PATCH RFC] frontend.c: Remove the BKL from agp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0910121209140.3658@localhost.localdomain>
Date:	Mon, 12 Oct 2009 12:11:51 +0200 (CEST)
From:	John Kacur <jkacur@...hat.com>
To:	Dave Airlie <airlied@...il.com>
cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	David Airlie <airlied@...ux.ie>,
	Jonathan Corbet <corbet@....net>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Vincent Sanders <vince@...tec.co.uk>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH RFC] frontend.c: Remove the BKL from agp_open



On Mon, 12 Oct 2009, Dave Airlie wrote:

> On Mon, Oct 12, 2009 at 6:24 AM, John Kacur <jkacur@...hat.com> wrote:
> >
> > @David Airlie. I was looking at the agp driver for removal of the bkl
> > lock. From what I could tell, the mutex_lock(&(agp_fe.agp_mutex)) should
> > cover what we need. However, I may have easily missed something, and would
> > appreciate your review / comments on the patch.
> 
> This seems fine, though I suck at locking logic,
> 
> One thing to note is the number of users of this interface is probably
> close to 0,
> so even if this does break something we probably won't ever find out.
> 
> Dave.
> 

Hmnn, you are listed as the maintainer - don't at least YOU use this 
driver? Also, if it seem fine to you, can I have an ack?

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/