linux-kernel - Re: [this_cpu_xx V6 3/7] Use this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AD3033C.8010503@kernel.org>
Date:	Mon, 12 Oct 2009 19:21:48 +0900
From:	Tejun Heo <tj@...nel.org>
To:	cl@...ux-foundation.org
CC:	linux-kernel@...r.kernel.org,
	Pekka Enberg <penberg@...helsinki.fi>,
	Mel Gorman <mel@....ul.ie>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Subject: Re: [this_cpu_xx V6 3/7] Use this_cpu operations in slub

Tejun Heo wrote:
> Hello,
> 
> cl@...ux-foundation.org wrote:
>> @@ -1507,7 +1498,7 @@ static inline void flush_slab(struct kme
>>   */
>>  static inline void __flush_cpu_slab(struct kmem_cache *s, int cpu)
>>  {
>> -	struct kmem_cache_cpu *c = get_cpu_slab(s, cpu);
>> +	struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu);
>>  
>>  	if (likely(c && c->page))
>>  		flush_slab(s, c);
>> @@ -1673,7 +1661,7 @@ new_slab:
>>  		local_irq_disable();
>>  
>>  	if (new) {
>> -		c = get_cpu_slab(s, smp_processor_id());
>> +		c = __this_cpu_ptr(s->cpu_slab);
> 
> Shouldn't this be this_cpu_ptr() without the double underscore?

Oh... another similar conversions in slab_alloc() and slab_free() too.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/