linux-kernel - linux-next: suspend tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091012140002.10f1f3d1.sfr@canb.auug.org.au>
Date:	Mon, 12 Oct 2009 14:00:02 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: linux-next: suspend tree build failure

Hi Rafael,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/base/power/main.c: In function 'device_pm_wait':
drivers/base/power/main.c:218: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
drivers/base/power/main.c:218: error: (Each undeclared identifier is reported only once
drivers/base/power/main.c:218: error: for each function it appears in.)
drivers/base/power/main.c:218: error: implicit declaration of function 'schedule'
drivers/base/power/main.c: In function 'dbg_show_time':
drivers/base/power/main.c:514: error: implicit declaration of function 'task_pid_nr'
drivers/base/power/main.c: In function '__device_resume_noirq':
drivers/base/power/main.c:551: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/base/power/main.c: In function '__device_resume':
drivers/base/power/main.c:713: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/base/power/main.c: In function '__device_suspend_noirq':
drivers/base/power/main.c:970: error: 'TASK_NORMAL' undeclared (first use in this function)
drivers/base/power/main.c: In function '__device_suspend':
drivers/base/power/main.c:1145: error: 'TASK_NORMAL' undeclared (first use in this function)

Presumably caused by commit d43c36dc6b357fa1806800f18aa30123c747a6d1
("headers: remove sched.h from interrupt.h") from Linus' tree.

I have added the following patch for today.

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Mon, 12 Oct 2009 13:48:27 +1100
Subject: [PATCH] suspend: using TASK_ macros requires sched.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/base/power/main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 3b09009..fb1c648 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -29,6 +29,7 @@
 #include <linux/async.h>
 #include <linux/completion.h>
 #include <linux/time.h>
+#include <linux/sched.h>
 
 #include "../base.h"
 #include "power.h"
-- 
1.6.4.3

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped