linux-kernel - Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091012125942.GA25464@elte.hu>
Date:	Mon, 12 Oct 2009 14:59:42 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>, lenb@...nel.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional


* Henrique de Moraes Holschuh <hmh@....eng.br> wrote:

> On Fri, 09 Oct 2009, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > Fix optional part of driver to be built optionally:
> 
> NAK!
> 
> This happens because of (linux-next) commit
> 7f6443f7238a0aa9014b11a0a31ab76825d75cdf 
> "thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by
> Ingo.
> 
> That commit is wrong, it must NOT be applied as explained in the 
> thread starting at http://lkml.org/lkml/2009/9/27/30.

Yep, that was wrong - it should be gone now.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/