linux-kernel - Re: [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0910120605q17a586dag29cf4ab6d89dd29d@mail.gmail.com>
Date:	Mon, 12 Oct 2009 09:05:57 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg KH <gregkh@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [origin tree build failure] [PATCH] Revert "USB: musb: make 
	HAVE_CLK support optional"

On Mon, Oct 12, 2009 at 03:42, Ingo Molnar wrote:
>
> * Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
>> As usual, please test this for regressions, both new and old.
>
>>       USB: musb: make HAVE_CLK support optional
>
> This USB/Blackfin commit broke the x86 build with these config options:
>
>  CONFIG_USB_MUSB_HDRC=y
>  CONFIG_USB_MUSB_HOST=y
>  # CONFIG_USB_MUSB_PERIPHERAL is not set
>  # CONFIG_USB_MUSB_OTG is not set
>  # CONFIG_USB_GADGET_MUSB_HDRC is not set
>  CONFIG_USB_MUSB_HDRC_HCD=y
>  CONFIG_MUSB_PIO_ONLY=y
>  CONFIG_USB_MUSB_DEBUG=y
>
> Because a side-effect of the patch was that it enabled the driver on x86
> too which doesnt have HAVE_CLK. So this formerly embedded-only driver
> got exposed on the more widely tested x86 platform.

this is dumb.  you're addressing unrealistic scenarios (randconfig) by
reverting code for realistic scenarios.  how about updating the
already present arch depend string instead.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/