linux-kernel - Re: [patch] Staging: hv: Fix vmbus load hang caused by wrong data packing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2009 08:30:13 -0700
From:	Greg KH <gregkh@...e.de>
To:	Haiyang Zhang <haiyangz@...rosoft.com>
Cc:	Hank Janssen <hjanssen@...rosoft.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tom Hanrahan <hanrahat@...rosoft.com>,
	Hashir Abdi <habdi@...rosoft.com>
Subject: Re: [patch] Staging: hv: Fix vmbus load hang caused by wrong data
 packing

On Sat, Oct 10, 2009 at 11:16:00PM +0000, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> Fix vmbus load hang caused by wrong data packing.
> 
> Cc: Hank Janssen <hjanssen@...rosoft.com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> ---
> diff --git a/drivers/staging/hv/ChannelMgmt.h b/drivers/staging/hv/ChannelMgmt.h
> index a839d8f..3f18584 100644
> --- a/drivers/staging/hv/ChannelMgmt.h
> +++ b/drivers/staging/hv/ChannelMgmt.h
> @@ -30,6 +30,8 @@
>  #include "VmbusChannelInterface.h"
>  #include "VmbusPacketFormat.h"
>  
> +#pragma pack(push,1)
> +
>  /* Version 1 messages */
>  enum vmbus_channel_message_type {
>  	ChannelMessageInvalid			=  0,
> @@ -54,24 +56,24 @@ enum vmbus_channel_message_type {
>  	ChannelMessageViewRangeRemove		= 18,
>  #endif
>  	ChannelMessageCount
> -} __attribute__((packed));

Why the change here?  Isn't this doing the same thing?

And I'm guessing that not all of these structures are needing to be
packed, right?  Are they all shared across the HV boundry?

And is this fixing the problem that Hank and users have reported with
the current code?  Does this need to get into the 2.6.32 release?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/