lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091012162600.GD1272@elte.hu>
Date:	Mon, 12 Oct 2009 18:26:00 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Greg KH <gregkh@...e.de>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [crash] NULL pointer dereference at IP: [<ffffffff812e9ccb>]
	uart_close+0x2a/0x1e4


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Mon, 12 Oct 2009, Ingo Molnar wrote:
> > 
> > Note, i have your fix below applied in tip:out-of-tree - it might be 
> > the source of this bug? (If yes then this isnt an .32-rc4 problem.)
> 
> If yes (but you later reported no), it would still be a 32-rc4 
> problem, because that patch got committed as 0b5759c654 ("tty: Avoid 
> dropping ldisc_mutex over hangup tty re-initialization").
> 
> So you shouldn't need it in the out-of-tree branch any more, and you 
> probably just never noticed because it all merged cleanly.

ah, indeed. I'll rebase that branch to clean out any 
went-upstream-already same-content patches. (Ideally that should empty 
it to a large degree.)

> Commit 46d57a449 (which you then bisected to) looks really irritating, 
> since it just renamed variables in annoying ways (ie the old "port" is 
> now "uport", and there's a new "port" that means something else). That 
> thing should have been split up to do the renaming separately, so that 
> a mis-use of "port" would have caused a compile error.
> 
> I'm not seeing anything obvious. Alan obviously found one bug already.

Thanks for checking. I'll try any debug patch from Alan.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ