linux-kernel - RE: [spi-devel-general] [PATCH] drivers/misc: add driver for TexasInstruments DAC7512

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2009 12:31:46 -0400
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	"Daniel Mack" <daniel@...aq.de>, <linux-kernel@...r.kernel.org>
Cc:	<spi-devel-general@...ts.sourceforge.net>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>
Subject: RE: [spi-devel-general] [PATCH] drivers/misc: add driver for TexasInstruments DAC7512

On Wednesday, October 07, 2009 1:01 PM, Daniel Mack wrote:
> This is actually too trivial to publish, but to export the function of
> that chip to the userspace, a module like this is needed.
> 
> Signed-off-by: Daniel Mack <daniel@...aq.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> Cc: spi-devel-general@...ts.sourceforge.net
> ---

[snip]

> +static ssize_t dac7512_store_val(struct device *dev,
> +				 struct device_attribute *attr,
> +				 const char *buf, size_t count)
> +{
> +	struct spi_device *spi = to_spi_device(dev);
> +	unsigned char tmp[2];
> +	unsigned long val;
> +
> +	if (strict_strtoul(buf, 10, &val) < 0)
> +		return -EINVAL;
> +
> +	tmp[0] = val >> 8;
> +	tmp[1] = val & 0xff;
> +	spi_write(spi, tmp, sizeof(tmp));
> +	return count;
> +}
> +
> +static DEVICE_ATTR(value, S_IWUSR | S_IRUGO,
> +		   NULL, dac7512_store_val);

You have declared the "value" device attribute with mode S_IWUSR | S_IRUGO
but have not provided a show callback.

Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/