linux-kernel - Re: [PATCH 05/21] amd_iommu.c: use pr_<level> and add pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1255366828.1839.55.camel@Joe-Laptop.home>
Date:	Mon, 12 Oct 2009 10:00:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	iommu@...ts.linux-foundation.org
Subject: Re: [PATCH 05/21] amd_iommu.c: use pr_<level> and add pr_fmt(fmt)

On Mon, 2009-10-12 at 17:00 +0200, Joerg Roedel wrote:
> On Sun, Oct 04, 2009 at 05:53:32PM -0700, Joe Perches wrote:
> > Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > Converted a few bare printks to pr_cont 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > ---
> >  arch/x86/kernel/amd_iommu.c |   71 ++++++++++++++++++++++--------------------
> >  1 files changed, 37 insertions(+), 34 deletions(-)
> Applied to amd-iommu/cleanups. Thanks Joe.

Hi Jeorg:

Looking back at the original patch:

> 	default:
> -		printk(KERN_ERR "UNKNOWN type=0x%02x]\n", type);
> +		pr_cont("\n");
> +		pr_err("UNKNOWN type=0x%02x]\n", type);

The default case probably had an incorrect KERN_ERR and should be

	pr_cont("UNKNOWN type=0x%02x]\n", type);

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/