linux-kernel - Re: [PATCH tracing/kprobes v3 6/7] perf: Add perf probe subcommand for kprobe-event setup helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091012190707.GJ17138@elte.hu>
Date:	Mon, 12 Oct 2009 21:07:07 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Masami Hiramatsu <mhiramat@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Hellwig <hch@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ibm.com>,
	"Frank Ch. Eigler" <fche@...hat.com>
Subject: Re: [PATCH tracing/kprobes v3 6/7] perf: Add perf probe subcommand
	for kprobe-event setup helper


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Wed, Oct 07, 2009 at 06:28:23PM -0400, Masami Hiramatsu wrote:
> > Add perf probe subcommand for kprobe-event setup helper to perf command.
> > This allows user to define kprobe events by C expressions (C line numbers,
> > C function names, and C local variables).
> >
> 
> 
> My libdwarf.h and dwarf.h are available through <libdwarf.h> and
> <dwarf.h>, these are in /usr/include
> 
> But even by fixing the include path in the makefile and probe-finder.h,
> I get the following build error:
> 
> util/probe-finder.c: In function ‘die_get_entrypc’:
> util/probe-finder.c:222: erreur: ‘Dwarf_Ranges’ undeclared (first use in this function)
> util/probe-finder.c:222: erreur: (Each undeclared identifier is reported only once
> util/probe-finder.c:222: erreur: for each function it appears in.)
> util/probe-finder.c:222: erreur: ‘ranges’ undeclared (first use in this function)
> cc1: warnings being treated as errors
> util/probe-finder.c:223: erreur: ISO C90 forbids mixed declarations and code
> util/probe-finder.c:247: erreur: implicit declaration of function ‘dwarf_get_ranges’
> util/probe-finder.c:247: erreur: nested extern declaration of ‘dwarf_get_ranges’
> util/probe-finder.c:251: erreur: implicit declaration of function ‘dwarf_ranges_dealloc’
> util/probe-finder.c:251: erreur: nested extern declaration of ‘dwarf_ranges_dealloc’
> make: *** [util/probe-finder.o] Erreur 1
> 
> 
> I remember we talked about that before, but I don't remember well why it happened.
> This is because of a libdwarf version or something, right?
> 
> Which one should I pick? Mine is:
> 
>     libdwarf.h  
> 
>     $Revision: #9 $ $Date: 2008/01/17 $

if it's possible to still have a single set of APIs it would be nice to 
auto-detect and massage all these libdwarf versions into a single 
backend within perf.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/