linux-kernel - Re: [PATCH] sound_core.c: Remove BKL from soundcore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hiqelf8ow.wl%tiwai@suse.de>
Date:	Mon, 12 Oct 2009 08:05:51 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	John Kacur <jkacur@...hat.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Jonathan Corbet <corbet@....net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vincent^M^J Sanders <vince@...tec.co.uk>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] sound_core.c: Remove BKL from soundcore_open

At Sun, 11 Oct 2009 14:41:15 +0200 (CEST),
John Kacur wrote:
> 
> @@ -631,17 +629,17 @@ static int soundcore_open(struct inode *inode, struct file *file)
>  		file->f_op = new_fops;
>  		spin_unlock(&sound_loader_lock);
>  		if(file->f_op->open)
> +			lock_kernel();
>  			err = file->f_op->open(inode,file);
> +			unlock_kernel();

You certainly want braces around here, no?


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/