linux-kernel - Re: [tip:x86/cleanups] x86: use kernel_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2009 17:35:57 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	ananth@...ibm.com, tglx@...utronix.de, mhiramat@...hat.com
CC:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/cleanups] x86: use kernel_stack_pointer() in kprobes.c

tip-bot for H. Peter Anvin wrote:
> Commit-ID:  98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Gitweb:     http://git.kernel.org/tip/98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Author:     H. Peter Anvin<hpa@...or.com>
> AuthorDate: Mon, 12 Oct 2009 14:14:10 -0700
> Committer:  H. Peter Anvin<hpa@...or.com>
> CommitDate: Mon, 12 Oct 2009 14:19:35 -0700
>
> x86: use kernel_stack_pointer() in kprobes.c
>
> The way to obtain a kernel-mode stack pointer from a struct pt_regs in
> 32-bit mode is "subtle": the stack doesn't actually contain the stack
> pointer, but rather the location where it would have been marks the
> actual previous stack frame.  For clarity, use kernel_stack_pointer()
> instead of coding this weirdness explicitly.
>
> Signed-off-by: H. Peter Anvin<hpa@...or.com>
> Cc: Ananth N Mavinakayanahalli<ananth@...ibm.com>
> Cc: Anil S Keshavamurthy<anil.s.keshavamurthy@...el.com>
> Cc: "David S. Miller"<davem@...emloft.net>
> Cc: Masami Hiramatsu<mhiramat@...hat.com>

Acked-by: Masami Hiramatsu <mhiramat@...hat.com>

Thank you for fixing it!


-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/