linux-kernel - Re: [PATCH] DaVinci: MMC: MMC/SD controller driver for DaVinci family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877hv0ql9s.fsf@deeprootsystems.com>
Date:	Mon, 12 Oct 2009 15:50:55 -0700
From:	Kevin Hilman <khilman@...prootsystems.com>
To:	Vipin Bhandari <vipin.bhandari@...com>
Cc:	linux-kernel@...r.kernel.org,
	davinci-linux-open-source@...ux.davincidsp.com,
	akpm@...ux-foundation.org, drzeus-mmc@...eus.cx
Subject: Re: [PATCH] DaVinci: MMC: MMC/SD controller driver for DaVinci family

Vipin Bhandari <vipin.bhandari@...com> writes:

> This patch adds support for MMC/SD controller driver for all DaVinci family
> SoC. This patch supports davinci family SoC's DM6446, DM355, DM365 and
> DA830/OMAPL137.
>
> The patch has been tested on DM355 EVM.
>
> The MMCSD controller specifications for DM355 can be found at
> http://focus.ti.com/general/docs/litabsmultiplefilelist.tsp?literatureNumber=spruee2c
>
> Signed-off-by: Vipin Bhandari <vipin.bhandari@...com>
> Signed-off-by: Purshotam Kumar <purushotam@...com>
> Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>

Vipin,

In addition to this, I've also been carrying the diff below in DaVinci
git.  Is this change still necessary?

Kevin


diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index fe8f613..6c76f64 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -178,7 +178,7 @@ struct mmc_davinci_host {
 	u32 buffer_bytes_left;
 	u32 bytes_left;
 
-	u8 rxdma, txdma;
+	u32 rxdma, txdma;
 	bool use_dma;
 	bool do_dma;
 
@@ -190,7 +190,7 @@ struct mmc_davinci_host {
 	struct edmacc_param	tx_template;
 	struct edmacc_param	rx_template;
 	unsigned		n_link;
-	u8			links[NR_SG - 1];
+	u32			links[NR_SG - 1];
 
 	/* For PIO we walk scatterlists one segment at a time. */
 	unsigned int		sg_len;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/