| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Oct 2009 17:01:28 +0900 From: Tejun Heo <tj@...nel.org> To: Mikael Pettersson <mikpe@...uu.se> CC: linux-kernel@...r.kernel.org Subject: Re: [PATCH 2.6.32-rc3] fix pcpu_embed_first_chunk() compile warnings Mikael Pettersson wrote: > Compiling 2.6.32-rc3 on i686 I get the following new warnings: > > mm/percpu.c: In function 'pcpu_embed_first_chunk': > mm/percpu.c:1873: warning: comparison of distinct pointer types lacks a cast > mm/percpu.c:1879: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'size_t' > > They are caused by 6ea529a2037ce662fc6bfa572b46d47407d08805 > "make embedding first chunk allocator check vmalloc space size". > > The first warning is because max() is applied to one operand of > type 'size_t' and another of type 'unsigned long'. Fix: cast the > second one to 'size_t'. > > For the second warning: always use '%z' to format 'size_t' operands. > > Signed-off-by: Mikael Pettersson <mikpe@...uu.se> For some reason, I've been thinking this was linux-next specific and committed about the same patch there, commit 3cbeae2f, a while ago. The only difference was use of max_t() instead of size_t cast. I think max_t() is cleaner there and will cherry pick the patch from linux-next. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists