linux-kernel - [PATCH] fcntl: rename F_OWNER_GID to F_OWNER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1255421603.8392.87.camel@twins>
Date:	Tue, 13 Oct 2009 10:13:23 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Michael Kerrisk <mtk.manpages@...glemail.com>,
	torvalds@...ux-foundation.org, eranian@...glemail.com, hch@....de,
	oleg@...hat.com, roland@...hat.com, viro@...iv.linux.org.uk,
	akpm@...ux-foundation.org, Ulrich Drepper <drepper@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] fcntl: rename F_OWNER_GID to F_OWNER_PGRP

I noticed this patch never quite made it to LKML..

---
Subject: fcntl: rename F_OWNER_GID to F_OWNER_PGRP
From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Date: Mon, 05 Oct 2009 14:44:47 +0200

On Sat, 2009-10-03 at 14:09 +0200, Michael Kerrisk wrote:
> Please, could you change F_OWNER_GID to F_OWNER_PGRP.
>
> This is for consistency with various ioctl() operations that include
> the suffix "PGRP" in their names, and also for consistency with
> PRIO_PGRP, used with setpriority() and getpriority(). Also, using PGRP
> instead of GID avoids confusion with the common abbreviation of "group
> ID".

I'm fine with anything that makes it more consistent, and if PGRP is
what is the predominant abbreviation then I see no need to further
confuse matters by adding a third one.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Acked-by: Michael Kerrisk <mtk.manpages@...il.com>
---
 fs/fcntl.c                  |    4 ++--
 include/asm-generic/fcntl.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/fs/fcntl.c
===================================================================
--- linux-2.6.orig/fs/fcntl.c
+++ linux-2.6/fs/fcntl.c
@@ -284,7 +284,7 @@ static int f_setown_ex(struct file *filp
 		type = PIDTYPE_PID;
 		break;
 
-	case F_OWNER_GID:
+	case F_OWNER_PGRP:
 		type = PIDTYPE_PGID;
 		break;
 
@@ -321,7 +321,7 @@ static int f_getown_ex(struct file *filp
 		break;
 
 	case PIDTYPE_PGID:
-		owner.type = F_OWNER_GID;
+		owner.type = F_OWNER_PGRP;
 		break;
 
 	default:
Index: linux-2.6/include/asm-generic/fcntl.h
===================================================================
--- linux-2.6.orig/include/asm-generic/fcntl.h
+++ linux-2.6/include/asm-generic/fcntl.h
@@ -80,7 +80,7 @@
 
 #define F_OWNER_TID	0
 #define F_OWNER_PID	1
-#define F_OWNER_GID	2
+#define F_OWNER_PGRP	2
 
 struct f_owner_ex {
 	int	type;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/