linux-kernel - Re: [patch 13/28] s390: Remove BKL from prng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 12:36:14 +0000
From:	Jan Glauber <jang@...ux.vnet.ibm.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Vincent Sanders <vince@...tec.co.uk>,
	John Kacur <jkacur@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Christoph Hellwig <hch@...radead.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [patch 13/28] s390: Remove BKL from prng

On Sat, 2009-10-10 at 15:36 +0000, Thomas Gleixner wrote:
> einfaches Textdokument attachment (s390-remove-bkl-from-prng.patch)
> cycle_kernel_lock() was added during the big BKL pushdown. It should
> ensure the serializiation against driver init code. In this case there
> is nothing to serialize. Remove it.

Looks good.
Acked-by: Jan Glauber <jang.linux.vnet.ibm.com>

-- Jan

> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> ---
>  arch/s390/crypto/prng.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> Index: linux-2.6-tip/arch/s390/crypto/prng.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/s390/crypto/prng.c
> +++ linux-2.6-tip/arch/s390/crypto/prng.c
> @@ -6,7 +6,6 @@
>  #include <linux/fs.h>
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> -#include <linux/smp_lock.h>
>  #include <linux/miscdevice.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> @@ -49,7 +48,6 @@ static unsigned char parm_block[32] = {
>  
>  static int prng_open(struct inode *inode, struct file *file)
>  {
> -	cycle_kernel_lock();
>  	return nonseekable_open(inode, file);
>  }
>  
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/