linux-kernel - Re: [PATCH RFC tip/core/rcu 1/3] rcu: The Bloatwatch Edition, v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091013170022.GA6782@linux.vnet.ibm.com>
Date:	Tue, 13 Oct 2009 10:00:22 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...ymtl.ca,
	josh@...htriplett.org, dvhltc@...ibm.com, niv@...ibm.com,
	tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org,
	Valdis.Kletnieks@...edu, dhowells@...hat.com, avi@...hat.com,
	mtosatti@...hat.com, torvalds@...ux-foundation.org
Subject: Re: [PATCH RFC tip/core/rcu 1/3] rcu: The Bloatwatch Edition, v7

On Tue, Oct 13, 2009 at 03:44:53PM +0800, Lai Jiangshan wrote:
> Again. trivial code-beautifying except the last one.
> 
> Paul E. McKenney wrote:
> 
> [...]
> 
> > +
> > +/* Global control variables for rcupdate callback mechanism. */
> > +struct rcu_ctrlblk {
> > +	struct rcu_head *rcucblist;	/* List of pending callbacks (CBs). */
> > +	struct rcu_head **donetail;	/* ->next pointer of last "done" CB. */
> > +	struct rcu_head **curtail;	/* ->next pointer of last CB. */
> > +};
> > +
> > +extern struct rcu_ctrlblk rcu_ctrlblk;
> > +extern struct rcu_ctrlblk rcu_bh_ctrlblk;
> 
> Since rcu_batches_completed() returns a constant, this piece of
> code is not needed here. We can move it to rcutiny.c.

Good point, moved.  And removed the "extern" declarations.

> and remove "EXPORT_SYMBOL_GPL(rcu_ctrlblk);" &
> "EXPORT_SYMBOL_GPL(rcu_bh_ctrlblk);".

Fixed, thank you!  And marked them "static".

> [...]
> 
> > +/* extern void rcu_restart_cpu(int cpu); */
> > +
> 
> redundant comments.

Good eyes!  I believe I have long since proven to myself that
rcu_restart_cpu() is no longer used.  :-)

> [...]
> 
> > +
> > +static inline int rcu_pending(int cpu)
> > +{
> > +	return 1;
> > +}
> 
> It seems that no one use it.

Indeed!  Removed.

> [...]
> 
> > +/* Definition for rcupdate control block. */
> > +struct rcu_ctrlblk rcu_ctrlblk = {
> > +	.rcucblist = NULL,
> > +	.donetail = &rcu_ctrlblk.rcucblist,
> > +	.curtail = &rcu_ctrlblk.rcucblist,
> > +};
> > +EXPORT_SYMBOL_GPL(rcu_ctrlblk);
> 
> remove "EXPORT_SYMBOL_GPL(rcu_ctrlblk);"

Done, above.

> > +struct rcu_ctrlblk rcu_bh_ctrlblk = {
> > +	.rcucblist = NULL,
> > +	.donetail = &rcu_bh_ctrlblk.rcucblist,
> > +	.curtail = &rcu_bh_ctrlblk.rcucblist,
> > +};
> > +EXPORT_SYMBOL_GPL(rcu_bh_ctrlblk);
> 
> remove "EXPORT_SYMBOL_GPL(rcu_bh_ctrlblk);"

Done, above.

> > +
> > +#ifdef CONFIG_NO_HZ
> > +
> > +static long rcu_dynticks_nesting = 1;
> > +
> > +/*
> > + * Enter dynticks-idle mode, which is an extended quiescent state
> > + * if we have fully entered that mode (i.e., if the new value of
> > + * dynticks_nesting is zero).
> > + */
> > +void rcu_enter_nohz(void)
> > +{
> > +	if (--rcu_dynticks_nesting == 0)
> > +		rcu_sched_qs(0); /* implies rcu_bh_qsctr_inc(0) */
> > +}
> > +
> > +/*
> > + * Exit dynticks-idle mode, so that we are no longer in an extended
> > + * quiescent state.
> > + */
> > +void rcu_exit_nohz(void)
> > +{
> > +	rcu_dynticks_nesting++;
> > +}
> > +
> > +#endif /* #ifdef CONFIG_NO_HZ */
> 
> It's an old issue.
> It's not only about RCUTINY, it's also about other rcu implementations:
> 
> rcu_enter_nohz()/rcu_exit_nohz() are not called in pairs.
> 
> irq_exit() calls tick_nohz_stop_sched_tick() which calls rcu_enter_nohz(),
> where is the corresponding rcu_exit_nohz()?
> (or tick_nohz_restart_sched_tick())?

The tick_nohz_restart_sched_tick() function is called from the various
per-architecture cpu_idle() functions (or default_idle() or whatever
name that the architecture uses).  For example, in:

	arch/x86/kernel/process_64.c

the cpu_idle() function invokes tick_nohz_restart_sched_tick() just
before invoking schedule() to exit the idle loop.

And, as you say, tick_nohz_restart_sched_tick() invokes rcu_exit_nohz().

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/