linux-kernel - Re: [PATCH 2/5] [PATCH 2/5] tracing: export symbols for kernel lock tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1255468491.7113.2409.camel@gandalf.stny.rr.com>
Date:	Tue, 13 Oct 2009 17:14:51 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/5] [PATCH 2/5] tracing: export symbols for kernel
 lock tracepoints

On Tue, 2009-10-13 at 22:43 +0200, Frederic Weisbecker wrote:
> On Tue, Oct 13, 2009 at 04:33:51PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@...hat.com>
> > 
> > The big kernel lock tracepoints are used inside modules and they need
> > to be exported accordingly.
> > 
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> > ---
> >  lib/kernel_lock.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/lib/kernel_lock.c b/lib/kernel_lock.c
> > index 4ebfa5a..76f05bc 100644
> > --- a/lib/kernel_lock.c
> > +++ b/lib/kernel_lock.c
> > @@ -139,3 +139,5 @@ void __lockfunc _unlock_kernel(const char *func, const char *file, int line)
> >  EXPORT_SYMBOL(_lock_kernel);
> >  EXPORT_SYMBOL(_unlock_kernel);
> >  
> > +EXPORT_TRACEPOINT_SYMBOL(lock_kernel);
> > +EXPORT_TRACEPOINT_SYMBOL(unlock_kernel);
> > -- 
> 
> 
> I remember when you showed me this patch, and it fixed a real
> issue because we had the tracepoint call in smp_lock.h:
> 
> #define lock_kernel()	\
> 	trace_lock_kernel(__FUNC__, __FILE__, __LINE__);	\
> 	_lock_kernel();						\
> 
> So indeed the modules needed this missing export. But I had
> to move the tracepoint calls to lib/kernel_lock.c instead,
> because we had very bad headers dependencies.
> 
> So it's not needed anymore.

Ah, I missed that change. I've had this queued up for a while.

Ingo, want me to rebase and remove this patch?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/