linux-kernel - Re: [Bug #14388] keyboard under X with 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0910131806310.6146@localhost.localdomain>
Date:	Tue, 13 Oct 2009 18:12:12 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Frédéric L. W. Meunier 
	<fredlwm@...il.com>
cc:	Boyan <btanastasov@...oo.co.uk>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	Nix <nix@...eri.org.uk>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Paul Fulghum <paulkf@...rogate.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Ed Tomlinson <edt@....ca>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Subject: Re: [Bug #14388] keyboard under X with 2.6.31

On Tue, 13 Oct 2009, Frédéric L. W. Meunier wrote:
> 
> For now (more than 3h), it isn't doing any harm. And no keyboard lockups.

I think it was Boyan who said he could trigger it "easily", and everybody 
else had a hard time to reproduce the problem, so I'll consider your "good 
for 3h" to not really be a confirmation either way. But at least it's not 
totally broken.

> BTW, the old version of the patch was funny. It booted, but at the login
> prompt I could only enter the first letter.

Yeah, each time somebody read from a tty, the reading would also get rid 
of all the buffers, but would leave buf.tail set to the last one (that had 
been freed). 

Which then resulted in all subsequent IO going to that tail buffer, but 
nobody ever seeing it, because 'head' was NULL, and would stay that way as 
long as 'tail' existed (which it would until the tty was flushed, which it 
would never be).

So you'd only ever see the first read (which could obviously be more than 
one character, but you'd have to type REALLY FAST to get there ;^)

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/