linux-kernel - Re: [PATCH v6 5/5]: mtdoops: refactor as a kmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091014171240.49d0963f@marrow.netinsight.se>
Date:	Wed, 14 Oct 2009 17:12:40 +0200
From:	Simon Kagstrom <simon.kagstrom@...insight.net>
To:	linux-mtd <linux-mtd@...ts.infradead.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Artem Bityutskiy <dedekind1@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Koskinen Aaro \(Nokia-D/Helsinki\)" <aaro.koskinen@...ia.com>,
	Ingo Molnar <mingo@...e.hu>,
	David Woodhouse <dwmw2@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH v6 5/5]: mtdoops: refactor as a kmsg_dumper

On Wed, 14 Oct 2009 15:41:24 +0200
Simon Kagstrom <simon.kagstrom@...insight.net> wrote:

> -static void __exit mtdoops_console_exit(void)
> +static void __exit mtdoops_exit(void)
>  {
>  	struct mtdoops_context *cxt = &oops_cxt;
>  
>  	unregister_mtd_user(&mtdoops_notifier);
> -	unregister_console(&mtdoops_console);
>  	kfree(cxt->name);

The kfree should go as well since cxt->name is no longer allocated. I'll
await further comments and send a new patch tomorrow.

// Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/