linux-kernel - Re: this_cpu_xx's patchset effect on SLUB cycle counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0910141125040.26476@gentwo.org>
Date:	Wed, 14 Oct 2009 11:31:29 -0400 (EDT)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	David Rientjes <rientjes@...gle.com>
cc:	Mel Gorman <mel@....ul.ie>, linux-kernel@...r.kernel.org,
	Pekka Enberg <penberg@...helsinki.fi>,
	Tejun Heo <tj@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Subject: Re: this_cpu_xx's patchset effect on SLUB cycle counts

On Tue, 13 Oct 2009, David Rientjes wrote:

> I benchmarked this patchset both with and without the irqless patch from
> http://marc.info/?l=linux-kernel&m=125503037213262 on several of my
> machines.  The results were good for the most part, but I found a very
> reproducible regression on my 4-core 8G Xeon 5500 with HyperThreading for
> objects of smaller size (8, 16, and 64 bytes) without the irqless patch:

Hmmm... Strange. Maybe different icache cacheline code placement? There is
no change in data structures without the irqless patch.

Can you change some kernel config options that impact memory and code
layout and rerun? Just to make sure that this is not a freak thing due to
code placement. Are sure sure that the kernel tested had the patches
applied?

> But "Kernel C" (with the irqless patch) shows a major improvement in the
> single threaded tests:

C changes per cpu layout a bit as well as does code changes.

> 2. Kmalloc: alloc/free test
> 10000 times kmalloc(8)/kfree -> 132 cycles

Was the kernel compiled with preemption on? I get cycle numbers with two
digits on these tests using quad nehalems.

> "Kernel C" hangs on my netserver machine during netperf -t TCP_RR -l 60,
> though, so hopefully I'll be able to obtain results for that benchmark
> with the irqless patch and see if there's any noticable improvement once
> it's debugged.

irqless is a risky patch. There may still be issues there. Thanks for
testing it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/